Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aosc): Add 'AOSC OS' support #5310

Merged
merged 6 commits into from
Jul 3, 2024
Merged

feat(aosc): Add 'AOSC OS' support #5310

merged 6 commits into from
Jul 3, 2024

Conversation

leavelet
Copy link
Contributor

@leavelet leavelet commented May 21, 2024 •
edited
Loading

Proposed Commit Message

feat(aosc): Add 'AOSC OS' support

Additional Context

AOSC OS is a general purpose Linux distribution under active maintenance by the Anthon Open Source Community since 2014. For further information, please visit the AOSC Portal.

Test Steps

Basic functionality tests have been successfully conducted on a Cloud environment powered by Openstack. Additionally, the cloud-init package has been merged into the main repository of AOSC OS.

However, we haven't released cloud images yet. You can download an iso, install the system manually, and runoma install cloud-init for testing purpose.

screenshot

Checklist

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@blackboxsw blackboxsw added the CLA signed The submitter of the PR has signed the CLA label May 27, 2024
@TheRealFalcon TheRealFalcon self-assigned this May 29, 2024
@TheRealFalcon
Copy link
Member

@leavelet , thanks for the contribution! Overall, I think things look good. Your newly added test fails. It looks like you need a mock to ensure hostnamectl doesn't get called on the system that unit tests are running on.
tests/unittests/test_cli.py::TestCLI::test_wb_schema_subcommand[all_spot_check] also fails, which checks the list of supported distros. Additionally, linting fails on cloudinit/distros/aosc.py:9:44: F401 [*] cloudinit.distros.rhel_util imported but unused.

@github-actions GitHub Actions
Copy link

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

@github-actions github-actions bot added the stale-pr Pull request is stale; will be auto-closed soon label Jun 13, 2024
@leavelet
Copy link
Contributor Author

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

Sorry for the delay! I've been tied up with other tasks recently, but I will complete this PR as soon as I can.

@holmanb holmanb removed stale-pr Pull request is stale; will be auto-closed soon labels Jun 13, 2024
@github-actions GitHub Actions
Copy link

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

@github-actions github-actions bot added the stale-pr Pull request is stale; will be auto-closed soon label Jun 28, 2024
@TheRealFalcon TheRealFalcon removed the stale-pr Pull request is stale; will be auto-closed soon label Jul 3, 2024
TheRealFalcon
TheRealFalcon approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheRealFalcon TheRealFalcon merged commit 9357c38 into canonical:main Jul 3, 2024
23 checks passed
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Aug 2, 2024
@leavelet @holmanb
feat(aosc): Add 'AOSC OS' support (canonical#5310)
4502b0f
holmanb pushed a commit that referenced this pull request Aug 6, 2024
@leavelet @holmanb
feat(aosc): Add 'AOSC OS' support (#5310)
72ba5c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealFalcon TheRealFalcon TheRealFalcon approved these changes

Assignees

@TheRealFalcon TheRealFalcon

Labels
CLA signed The submitter of the PR has signed the CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leavelet @TheRealFalcon @blackboxsw @holmanb